Skip to content

feat: add stats/incr/nanmin #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 27, 2025
Merged

feat: add stats/incr/nanmin #5917

merged 5 commits into from
Sep 27, 2025

Conversation

abhishekblue
Copy link
Contributor

Resolves #5551

Description

What is the purpose of this pull request?

This pull request:

  • introduces the @stdlib/stats/incr/nanmin package, which incrementally computes a minimum value, ignoring NaN values.

Related Issues

No.

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@abhishekblue
feat(stats/incr): add
62faf2b 
anmin package to handle NaN values
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 9, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmin $\color{green}134/134$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}134/134$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@abhishekblue abhishekblue changed the title feat(stats/incr): add nanmin package to handle NaN values feat: add nanmin package to handle NaN values Mar 31, 2025
@abhishekblue abhishekblue mentioned this pull request Mar 31, 2025
Closed
7 tasks
@kgryte kgryte changed the title feat: add nanmin package to handle NaN values feat: add stats/incr/nanmin Apr 2, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 2, 2025
@kgryte kgryte self-requested a review April 2, 2025 05:05
@Planeshifter Planeshifter self-requested a review September 27, 2025 19:31
@Planeshifter
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 27, 2025
@Planeshifter
chore: minor clean-up
6eec469 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter
Planeshifter approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this one! Thx!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Sep 27, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 27, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `stats/incr/nanmin`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5917
Closes: https://github.com/stdlib-js/stdlib/issues/5551

Co-authored-by: Abhishek Jain <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: abhishekblue <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 091c2e0 into stdlib-js:develop Sep 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmin
4 participants
@abhishekblue @stdlib-bot @Planeshifter @kgryte